Repository navigation
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
概要
PR #2 を main にマージした後、その main から分岐したスタイル基盤のリファクタです。見た目・文言・操作・Rustの意味論を変更せず、Tailwindと既存スタイルをMaster CSSへ移行します。
mode: 'static'で本番CSSを生成し、ブラウザのCSSランタイムは追加しません。@composeに移行。色はsrc/styles/tokens.cssに集約。検証
手元の未コミットRust作業は含めず、ステージしたWebファイルとコミット済みsubmoduleの独立スナップショットで検証しました。
cargo test --workspace --quietcargo fmt --all -- --checkcargo clippy --workspace --all-targets --all-features -- -D warningsnpm run buildnpm run lint編集画面の比較対象では計算済みCSSの差分なし。Viewer/Previewの差分はTailwindが合成していた透明なゼロサイズshadowの削除のみです。CSS配信量は約86.85kBから75.06kBへ減少しました(KaTeX込み、非gzip)。
注意点
npm auditには既存の開発依存由来の11件(critical 1件を含む)が残ります。該当バージョンは移行前から存在し、本PRで無関係な依存更新は行っていません。