Unnecessary line in class Create

[oam333]

Method "setBody" of class "Create" has unnecessary line # 37 (of origin file /phpClient/vendor/manticoresoftware/manticoresearch-php/src/Manticoresearch/Endpoints/Indices/Create.php).

See comment inside code:

public function setBody($params = null)
{
    if (isset($this->index)) {
        $columns = [];
        if (isset($params['columns'])) {
            foreach ($params['columns'] as $name => $settings) {
                $column = $name . ' ' . $settings['type'];
                if (isset($settings['options']) && count($settings['options']) > 0) {
                    $column .= ' ' . implode(' ', $settings['options']);
                }
                $columns[] = $column;
            }
        }
        $options = "";
        if (isset($params['settings'])) {
            foreach ($params['settings'] as $name => $value) {
                $options.=" ".$name." = '".$value."'";       // ##### <----- this line is unneccessary, because the same code lower in "else" block
                if (is_array($value)) {
                    foreach ($value as $v) {
                        $options.=" ".$name." = '".$v."'";
                    }
                } else {
                    $options.=" ".$name." = '".$value."'"; // #### <----- the same code
                }
            }
        }
        return parent::setBody(['query' => "CREATE TABLE ".
            (isset($params['silent']) && $params['silent']===true?' IF NOT EXISTS ':'').
            $this->index.
            (count($columns)>0?"(".implode(",", $columns).")":" ")
            .$options]);
    }
    throw new RuntimeException('Index name is missing.');
}

[sanikolaev]

Hello @oam333

Thank you for this issue. We'll be glad to accept your pull request.

[marclaporte]

@oam333 I know it has been 5 years but I am doing some housecleaning here :-) What is latest status for you?

Manticore has had multiple innovations and releases:
https://github.com/manticoresoftware/manticoresearch/releases