Repository navigation
chore(deps): upgrade MMKV with aligned native dependencies - #1057
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
boorad
force-pushed
the
dependabot/bun/main/react-native-mmkv-4.3.1
branch
from
October 28, 2026 14:59
4ff33c9 to
7a32f41
Compare
Collaborator
Collaborator
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Upgrade the example app to MMKV 4.3.1 with its native dependencies aligned: MMKVCore 2.4.0 in CocoaPods and Nitro runtime 0.35.0 in the example and library development environment. The original Dependabot change updated only the JavaScript lockfile; the locked iOS install failed because it still required MMKVCore 2.2.4. MMKV 4.2+ also requires Nitro 0.35.0 or newer.
The four-file change updates dependency pins and lockfiles only. The library’s public Nitro peer range, generated C++ specs and crypto implementation are unchanged. Merging updates the example/development environment; it does not publish a library release.
AgentSCM alpha.8 adoption example
This PR demonstrates the workflow after #1086 switched GitHub to the prebuilt alpha.8 verifier. Its first hosted run passed binary acquisition/provenance, version verification and status reconciliation:
local-validation postto attach its signed evidence. GitHub’s trusted default-branch verifier checks the signature and bindings and publishesagentscm/local-validation.The first local reproduction failed during CocoaPods setup, and alpha.8 signed that failure; its standalone verifier returned
failureand rejected the same evidence against a different head. After the dependency fixes, both platforms passed. Old June hosted-test comments below refer to the original PR head and are superseded by evidence for the new head.Validation
Exact head:
7a32f415423e35bca53f727dd72d660cf2424aab, rebased onto the alpha.8 verifier migration at60f75fc102ecbbd05a15aa13b7c3e5b01ec6fee3.local-validation runafter rebase:pass; standaloneverify:success, “attestation satisfies the exact head”.c546ff5aba54fdd3f08358a8ae77c3992b153e01a8ab1acd8c2239bec49c4ed8.bun lint, andbun formatpassed before the CI-only rebase;git range-diffconfirms both dependency commits are unchanged.agentscm/local-validationis green.Reproduce
Follow docs/local-e2e.md for key enrollment, trust checks and installation. With the exact published binary installed:
What the check means
The mobile suites execute on the enrolled maintainer’s Mac, not on GitHub. The attestation is
worker_asserted: the signature binds the reported result to the exact source and policy; it does not independently prove execution or host integrity. GitHub runs the verifier using the pinned prebuilt release.Alpha.8’s comment renderer warns about absent PostgreSQL/S3 even when policy marks them not required. RNQC requires neither service; both policy flags are
false, and that generic warning does not make this attestation fail. The iOS/Android suites are crypto-app qualification, not an exhaustive MMKV persistence test suite. Known verifier setup-failure limits remain documented in the linked guide.