Skip to content

listenTo equivalents for Commands and Requests. - #157

Open
jamesplease wants to merge 2 commits into
minorfrom
listen-to-equivalent
Open

jamesplease wants to merge 2 commits into
minorfrom
listen-to-equivalent

Conversation

@jamesplease

Copy link
Copy Markdown
Member

WIP

Resolves #117

  • Add stopListening equivalents
  • Abstract logic to remove duplication
  • Tests
  • Docs

@jamesplease
jamesplease force-pushed the listen-to-equivalent branch 2 times, most recently from fc6175d to f9a096a Compare October 26, 2014 04:24
@coveralls

Copy link
Copy Markdown

Coverage Status

Coverage decreased (-10.81%) when pulling f9a096a on listen-to-equivalent into 1ceb392 on minor.

@megawac

megawac commented Oct 26, 2014

Copy link
Copy Markdown
Member

Seems like a lot of duplicate code in here

@jamesplease

Copy link
Copy Markdown
Member Author

Yeah. I'll abstract it more after I've added tests to verify that the behavior is what I want.

@coveralls

Copy link
Copy Markdown

Coverage Status

Coverage remained the same when pulling 84b9172 on listen-to-equivalent into ccb3468 on minor.

@jamesplease

Copy link
Copy Markdown
Member Author

Note to future self: this is possibly blocked by #162.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants