Name five collision functions - #23
Open
Hackerman696 wants to merge 1 commit into
Open
Hackerman696 wants to merge 1 commit into
Hackerman696 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This names five previously address-derived MP7 DOL collision functions in
config/GP7E01/symbols.txt, using the same names as their MP5 and MP6 equivalents.Evidence
0x80077F00fn_80077F00ColEjectDistGet0x80078494fn_80078494ColPlaneDistGet0x800789C0fn_800789C0_EdgeCylCol0x8007ACD4fn_8007ACD4_ColCapsuleVtxCalc0x800821B0fn_800821B0ColDirtyClearMP4 does not supply lineage evidence for these five functions. The supporting evidence is the manual Milestone 5C forensic review: MP5 provides named C/source anchors, MP6 provides named binary/generated-asm anchors, and each MP7 target remains a generic DOL symbol in
main/game/colman.Verification
python3 configure.py --version GP7E01 --wrapper wibo --mapninja -j1ninja -j1 build/GP7E01/okninja -j1 diffbuild/GP7E01/okreported130 files OK.build/GP7E01/main.elf.MAPcontains the five new names at0x80077f00,0x80078494,0x800789c0,0x8007acd4, and0x800821b0.config/GP7E01/symbols.txtwith five insertions and five deletions.Scope
This is a symbol-only change. It does not decompile or modify the surrounding
game/colman.ccollision translation unit, add aliases, edit headers, or alter generated files.