MLE-31399 update janino to 3.1.12 - #661
Merged
Merged
Conversation
RitaChen609
requested review from
jonmille,
ngodugu-marklogic,
rjdew-progress and
rjrudin
as code owners
July 30, 2026 14:27
Contributor
There was a problem hiding this comment.
Pull request overview
This PR addresses CVE-2023-33546 / BDSA-2023-1535 by introducing a centralized Gradle resolution strategy that forces all org.codehaus.janino dependencies to use Janino 3.1.12, ensuring transitive pulls (e.g., via Spark/logging stacks) are overridden consistently across subprojects.
Changes:
- Added
janinoVersion=3.1.12togradle.propertiesfor centralized version management. - Added a
resolutionStrategy.eachDependencyrule inbuild.gradleto forceorg.codehaus.janinoartifacts to${janinoVersion}with an explanatorybecauseclause.
Reviewed changes
Copilot reviewed 1 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| gradle.properties | Introduces a shared janinoVersion property set to 3.1.12. |
| build.gradle | Forces all dependencies in org.codehaus.janino to the configured janinoVersion via Gradle resolution strategy. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
rjrudin
approved these changes
Jul 30, 2026
jonmille
approved these changes
Jul 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed BDSA-2023-1535 / CVE-2023-33546 in Janino v3.1.9 by forcing Janino to 3.1.12.