Skip to content

To preserve the mathcomp CI (forward dependency) for PR#1611 #1987

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
gbdrt wants to merge 1 commit into
base: master
Choose a base branch
from
Open

To preserve the mathcomp CI (forward dependency) for PR#1611 #1987

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions classical/unstable.v
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,6 +47,20 @@ Unset Printing Implicit Defensive.
Import Order.TTheory GRing.Theory Num.Theory.
Local Open Scope ring_scope.

(* Backward compatibility with math-comp < 2.6, which has no [conjFieldType]
(the common ancestor of [rcfType] and [numClosedFieldType]). When it is
absent we alias it to [rcfType] via a global parsing-only abbreviation, so
that MCA files endowing [conjFieldType] with topological/normed structures
still compile: those instances then become redundant copies of the [rcfType]
ones (their [HB.no-new-instance] is silenced at each site). *)
Elpi Command analysis_declare_conjFieldType_compat.
Elpi Accumulate lp:{{
main [] :- coq.locate-all "Num.ConjField.type" L, L = [_|_], !.
main [] :- @global! => coq.notation.add-abbreviation "conjFieldType" 0
{{ Num.RealClosedField.type }} tt _.
}}.
Elpi analysis_declare_conjFieldType_compat.

Section IntervalNumDomain.
Variable R : numDomainType.
Implicit Types x : R.
Expand Down
10 changes: 10 additions & 0 deletions theories/normedtype_theory/normed_module.v
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -221,6 +221,16 @@ HB.instance Definition _ := NormedModule.copy R R^o.
HB.instance Definition _ := Num.ClosedField.on R.
End numClosedFieldType.

Section conjFieldType.
Variable R : conjFieldType.
#[export, non_forgetful_inheritance, warnings="-HB.no-new-instance"]
HB.instance Definition _ := GRing.ComAlgebra.copy R R^o.
#[export, non_forgetful_inheritance, warnings="-HB.no-new-instance"]
HB.instance Definition _ := Vector.copy R R^o.
#[export, non_forgetful_inheritance, warnings="-HB.no-new-instance"]
HB.instance Definition _ := NormedModule.copy R R^o.
End conjFieldType.

Section numFieldType.
Variable (R : numFieldType).
#[export, non_forgetful_inheritance]
Expand Down
6 changes: 6 additions & 0 deletions theories/topology_theory/num_topology.v
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,8 @@
(* mathcomp analysis (c) 2026 Inria and AIST. License: CeCILL-C. *)
From HB Require Import structures.
From mathcomp Require Import all_ssreflect_compat all_algebra all_classical.
#[warning="-warn-library-file-internal-analysis"]
From mathcomp Require Import unstable.
From mathcomp Require Import interval_inference reals topology_structure.
From mathcomp Require Import uniform_structure pseudometric_structure.
From mathcomp Require Import order_topology matrix_topology.
Expand Down Expand Up @@ -130,6 +132,10 @@ HB.instance Definition _ (R : realFieldType) := PseudoPointedMetric.copy R R^o.
HB.instance Definition _ (R : numClosedFieldType) :=
PseudoPointedMetric.copy R R^o.

#[export, non_forgetful_inheritance, warnings="-HB.no-new-instance"]
HB.instance Definition _ (R : conjFieldType) :=
PseudoPointedMetric.copy R R^o.

#[export, non_forgetful_inheritance]
HB.instance Definition _ (R : numFieldType) := PseudoPointedMetric.copy R R^o.

Expand Down
Loading