refactoring and correction in examples/cat.v#587
Open
t6s wants to merge 2 commits into
Open
Conversation
t6s
changed the title
t6s
changed the title
examples/cat.v
* make \o the primary notation and \; parsing only * change the comp axioms to be about comp, not seq * fix (co)monad laws and their names * add IsCat factory * add IsFunctor factory * add IsExtensionMonad factory Co-authored-by: @affeldt-aist Co-authored-by: @shinya-katsumata
Member
Author
|
Can you take a look at this? @CohenCyril |
CohenCyril
reviewed
May 27, 2026
CohenCyril
left a comment
CohenCyril
left a comment
Member
There was a problem hiding this comment.
Looks better to me. Thanks for the improvement.
Just one remark.
| Arguments comp {C} {a b c} : rename. | ||
| Notation "f \o g" := (comp g f) : cat_scope. | ||
| Notation "f \; g :> T" := (@comp T _ _ _ f g) | ||
| Notation "f \; g :> T" := (@comp T _ _ _ g f) |
Member
There was a problem hiding this comment.
I'd keep \; as a parsing and printing notation but with an alias, as in ssrfun:
https://github.com/rocq-prover/rocq/blob/3b3c606ac062925ae66e1306b8570e50a9c09333/theories/Corelib/ssr/ssrfun.v#L464-L480
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix #583, #584, #585
Co-authored-by: @affeldt-aist
Co-authored-by: @shinya-katsumata