Repository navigation
docs: fix three stale comments in src/index.ts - #438
Merged
Merged
Conversation
- The userAgent comment said it is lowercased so indexOf() can be used instead of a regex; three regexes now run against it too. It is lowercased so both kinds of check can skip case-insensitive flags. - The includes() helper was described as "Check if element exists"; it is a substring test. - noConflict() still referred to the library's old name, device.js. Comments only; the minified bundle is byte-identical. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The "stale comments" item in #421. Comments only; no code changes.
televisionModel,androidTabletModel,androidFoldablePhone) run against it now.includes()helperneedleoccurs anywhere inhaystack", which is what it does.deviceglobal back to its previous value, for pages where the name is taken) and drops the library's old name.No changeset: nothing observable changes.
Test plan
dist/index.global.jsis byte-identical before and afterpnpm exec biome ci,pnpm run typecheck,pnpm run test(642 passed, 1 expected failure)Generated by Claude Code