Fix multiline Setext heading breaks and underline widths - #279
Open
jackwalkerlabs wants to merge 1 commit into
Open
Fix multiline Setext heading breaks and underline widths#279jackwalkerlabs wants to merge 1 commit into
jackwalkerlabs wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Preserve
<br>line boundaries in level-1/2 Setext headings and size their underline to the longest text line instead of counting the whole multiline string. ATX headings and table-cell inline conversion keep their existing single-line behavior.Fixes #225 for valid
<br>markup and literal newlines. The issue’s</br>spelling is malformed HTML and remains subject to the selected BeautifulSoup parser’s handling.Validation: the regression fails on the base; all 84 tests pass after the change. Flake8 and README reStructuredText lint pass. Cases cover both heading levels, longer first/last lines, mixed break markup, empty headings, ATX, and headings inside table cells.
AI disclosure: Implemented, reviewed, and tested by OpenAI Codex under the account owner’s authorization; no human code review is claimed.