Preserve text spacing in anchors without destinations - #281
Open
oyeong011 wants to merge 1 commit into
Open
Conversation
Return unlinked anchor content before trimming link-label whitespace so adjacent words remain separated. Confidence: high Scope-risk: narrow Tested: 84 tests; public API and CLI; nested spans Not-tested: Alternative BeautifulSoup parsers
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
left<a> middle </a>rightcurrently converts toleftmiddleright. An anchor without a destination is emitted as plain text, butconvert_afirst strips its boundary whitespace as if it were constructing a link label.Return destinationless anchor content before trimming. This preserves word boundaries for missing/empty
href, named anchors, whitespace-only content, and nested inline markup.Validation: all 84 tests passed on Python 3.11; public API and actual CLI checks passed, including 50 nested spans. Related open PRs #262 (destination escaping) and #280 (emphasis boundary line breaks) were inspected and do not fix destinationless-anchor whitespace. Alternative BeautifulSoup parsers were not tested.
AI disclosure: this patch and its tests were prepared with OpenAI Codex and verified by executing the tests and CLI.