Repository navigation
Conversation
Signed-off-by: AC <ac@fabtek.cn>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #286. Thanks to @BrianWillows for reporting and identifying the replacement; this PR applies that fix and adds regression coverage.
The default
<pre>conversion repeatedly searches a long indentation run for trailing whitespace. Replace the trailing regex substitution withrstrip(' \n'), preserving indentation and the exact set of stripped characters. Keep the module-level regex name for compatibility.On Python 3.8.20/Linux arm64, the same public
markdownify()input (spaces followed byx) measured:These are local single-run measurements, not a portable speed guarantee. The regression test checks both preserved indentation and a generous five-second bound (the fixed conversion takes milliseconds). Ten additional public API cases cover indentation, empty/blank input and whitespace that must remain. A separate exhaustive comparison of all 29,524 strings of length 0–9 over space/newline/
xfound no output differences instrip_pre.Validation:
mypy .andmypy --strict tests/types.pypass on the clean source tree.git diff --checkpasses.Build artifacts were moved out before mypy, because scanning
build/libduplicates the source module. Tests use the public conversion API; no stub changes are needed.AI assistance: implemented, independently reproduced and tested with Codex.