Fix broken Symfony event subscribers link on branch 7.1 - #654
Conversation
…ck build Ports the fix from PR mautic#624 (branch 7.2) to branch 7.1. Symfony moved the event dispatcher page out of /components/ and renamed the section anchor, so the old #using-event-subscribers anchor 404s and fails the linkcheck build. Point the xref at the current page and anchor.
|
Just a reminder: I review PR comments by default. If you want me to ignore a specific comment, start it with |
|
@promptless-for-oss apparently build checks in other branches also have failed because of the same borken link. Please cherry pick this to other branches as well. |
|
On it, @adiati98 — I'll check the other maintained branches (5.x, 6.0, 7.0) for the same broken link and open a port PR against each one that still has it. I'll follow up here with the links. |
|
Update: confirmed the same broken link is still present on all three remaining maintained branches (5.x, 6.0, 7.0), so each fails the linkcheck the same way. Opening a port PR against each one now. |
|
Thanks @adiati98 — you were right, the broken Symfony "event subscribers" link was failing the linkcheck build on the other maintained branches too. I verified that 7.0, 6.0, and 5.x all still pointed at the old, removed Symfony anchor, and opened a fix PR for each:
Each applies the same one-line change already merged in #624/#654, updating the cross-reference to Symfony's current event dispatcher page and anchor; the visible link text is unchanged. |
Ports the broken-link fix from PR #624 (branch 7.2) / #654 (branch 7.1) to branch 6.0, as requested by maintainer @adiati98. The Symfony event dispatcher page moved out of /components/ and the section anchor was renamed, so the old #using-event-subscribers anchor returned 'Anchor not found' and failed the docs linkcheck build. The xref now points to the current Symfony page and anchor. Visible link text is unchanged.
Ports the broken-link fix from PR #624 (branch 7.2) / #654 (branch 7.1) to branch 7.0, as requested by maintainer @adiati98. The Symfony event dispatcher page moved out of /components/ and the section anchor was renamed, so the old #using-event-subscribers anchor returned 'Anchor not found' and failed the docs linkcheck build. The xref now points to the current Symfony page and anchor. Visible link text is unchanged.
Ports the broken-link fix from PR #624 (branch 7.2) / #654 (branch 7.1) to branch 5.x, as requested by maintainer @adiati98. The Symfony event dispatcher page moved out of /components/ and the section anchor was renamed, so the old #using-event-subscribers anchor returned 'Anchor not found' and failed the docs linkcheck build. The xref now points to the current Symfony page and anchor. Visible link text is unchanged.
2 participants
Open in Promptless
Ports the broken-link fix from PR #624 (branch 7.2) to branch 7.1, as requested by maintainer @adiati98. The "event subscribers" cross-reference on the Plugin event listeners page pointed to a Symfony docs anchor that no longer exists — Symfony moved the event dispatcher page out of
/components/and renamed the section anchor — so the old#using-event-subscribersanchor returned "Anchor not found" and failed the docs linkcheck build. The xref now points to the current Symfony page and anchor. Visible link text is unchanged.Trigger Events