Correct Embedded Form note: snippets use the configured Site URL - #936
Merged
adiati98 merged 3 commits intoSep 4, 2026
Merged
Conversation
The Embedded Form JavaScript and IFrame snippets now use the configured Site URL rather than the current admin host (mautic/mautic PR #17193). Update the Embedded note in forms.rst accordingly and add a cross-reference to the Site URL configuration setting.
promptless-for-oss
requested review from
a team,
adiati98 and
favour-chibueze
September 1, 2026 14:44
adiati98
reviewed
Sep 4, 2026
Contributor
Author
|
Thanks @adiati98 — on it. We'll swap the em dashes for hyphens and rewrite the passive-voice sentences in active voice to match the style guide, then push the update to this PR. |
Address @adiati98's review on PR mautic#936: - Convert em dashes to spaced hyphens in the Embedded Form note - Rewrite passive 'If Site URL isn't set' as active 'If you haven't set the Site URL'
Contributor
Author
|
Done, @adiati98 — both changes are in and pushed to this PR:
Vale ran clean on the changed file (no new findings). Ready for another look whenever you have a moment. |
adiati98
approved these changes
Sep 4, 2026
adiati98
left a comment
adiati98
left a comment
Contributor
There was a problem hiding this comment.
Thanks for the review, @patrykgruszka! 🚀
promptless-for-oss
deleted the
promptless/pr-17193-embedded-form-site-url
branch
September 4, 2026 09:33
Contributor
|
@all-contributors please add @patrykgruszka for review. |
Contributor
|
I've put up a pull request to add @patrykgruszka! 🎉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Open in Promptless
The Embedded Form JavaScript and IFrame snippets now use your configured Site URL — its scheme, host, and base path — rather than the domain of the admin host you're currently viewing Mautic on. This corrects the note under the Embedded heading in the Forms docs, which previously told users to be on the correct domain because the embed code referenced the current URL. The note now explains that the Embedded snippets use the configured Site URL, points readers to set it under Configuration > System Settings > General Settings, and notes the fallback to the current request host when Site URL is unset. A cross-reference to the Site URL configuration setting is added. The Self-hosted (manual copy) note is unchanged, since those snippets still reference the current host.
Trigger Events