Document Marketplace ratings and reviews, and campaign sharing to the Marketplace - #939
Conversation
… Marketplace Documents the user-facing Marketplace changes from mautic/mautic PR #15904 (New Marketplace API, review, rating), merged to 7.x. Targets the 7.2 docs branch. - docs/marketplace/marketplace.rst: new Ratings and reviews section; Rate & Review now redirects to the public Mautic Marketplace website. - docs/campaigns/exporting_campaigns.rst: Export now opens a Share form offering Download ZIP and Publish. - docs/links/marketplace_mautic_org.py: new xref registry entry.
| Submitting a review | ||
| =================== | ||
|
|
||
| To submit a review for a Plugin, click **Rate & Review** in the context menu. This takes you to the public Mautic Marketplace website at :xref:`Mautic Marketplace website` where you can sign in and leave your review. |
There was a problem hiding this comment.
Verified on mautic/mautic 7.x (commit 504af18c): the "Rate & Review" button on the Plugin detail page (id 'ratePackage') is defined with 'primary': true, class 'btn btn-primary btn-nospin', icon 'ri-star-line', href = marketplaceWebsiteUrl ~ '/package/' ~ vendor ~ '/' ~ package, and target='_blank'. ButtonHelper::orderButtons() (CoreBundle/Twig/Helper/ButtonHelper.php) sorts primary=true buttons to the front (priority 215) and outside the Options dropdown (listMarker), confirming it renders as a standalone primary button, not a dropdown/context-menu item. Label 'mautic.marketplace.rate.package' = "Rate & Review" (MarketplaceBundle/Translations/en_US/messages.ini). Context menu (Close/Install/Issue tracker) correctly has no Rate & Review bullet.
There was a problem hiding this comment.
Checked against 7.x - the class changes are right (RateController and Auth0 gone, Review DTO and ReviewCollection present). Three fixes:
- Not in the context menu. It's 'primary': true in Package/detail.html.twig, and primary buttons render standalone on the detail page, not in the dropdown. The "Context menu" bullet needs the same fix.
- Not a redirect. target="_blank", and it points at the package's own page — /package/{vendor}/{name} — not the site root the xref resolves to.
- No marketplace-api.mautic.org. Config/config.php sets both MARKETPLACE_WEBSITE_URL and MARKETPLACE_REGISTRY_URL to https://marketplace.mautic.org.
| #. Click the three-dot icon next to the Campaign's name that you want to export to open the options. | ||
| #. Select the **Export** option from the dropdown menu. It automatically downloads the ZIP file. | ||
| #. Open the options for the Campaign you want to export. These are available from the three-dot icon on the Campaign list row and from the Campaign detail page. | ||
| #. Select the **Export** option. Instead of downloading immediately, Mautic opens a **Share** form. |
There was a problem hiding this comment.
Verified on mautic/mautic 7.x (commit 504af18c), CampaignBundle/Form/Type/CampaignShareType.php: five NotBlank fields - title (label 'mautic.campaign.share.title'="Name"), vendorName (label "Vendor Name", Regex '^(?!mautic$)a-z0-9?$'), version (label "Package Version", semver Regex, default data '1.0.0'), headline (label "Headline", Length max:60), description (label "Description", Length min:100). Labels confirmed in CampaignBundle/Translations/en_US/messages.ini lines 257-269. Optional fields: keywords (required:false), worksWithVersions (ChoiceType, required:false, but Count(min:1) constraint applies only in validation group 'publish' - i.e. required only when clicking Publish), languages (required:false). Images: bannerImage plus galleryImage1..8/galleryAlt1..8 (8 gallery slots in code; doc correctly avoids stating a specific max count since in-product help text says "up to 5" while code allows 8 - a known product mismatch).
There was a problem hiding this comment.
Routing and ZIP details check out. Two corrections:
- headline is also required - CampaignShareType has NotBlank on title, vendorName, version, headline and description. Five, not four.
- The UI labels differ from the field names: users see "Name", "Vendor Name" and "Package Version".
Worth adding: description has a 100 character minimum, and the form also has Keywords, Works with and Languages. Images is a Banner Image plus a Gallery of up to 5, each with ALT text.
adiati98
left a comment
There was a problem hiding this comment.
@promptless-for-oss please address the Vale warnings.
|
Thanks, @adiati98 — on it. We'll run Vale on the changed files and fix the flagged warnings, then follow up here once pushed. |
|
Update: we ran Vale on both changed files and are reworking the flagged lines — converting the passive "Reviews are managed…" sentence to active voice and rewording the false-positive term hits (e.g. "page", "form", "Publish" where they aren't the Mautic feature) without changing any documented behavior. We'll push shortly. |
Reword changed lines to clear Mautic.FeatureList and Google.Passive Vale
findings flagged on the PR diff, without altering documented behavior:
- marketplace.rst: 'other users' opinions' -> 'other people's opinions';
'Plugin detail page' -> 'When you open a Plugin' (avoids the page swap and
the detail-page/detail-view inconsistency); 'other Mautic users' ->
'other community members'; active-voice note ('The public Mautic
Marketplace website manages reviews').
- exporting_campaigns.rst: 'Campaign detail page' -> 'detail view'; removed
bare-verb 'publishing'; fixed ambiguous pronoun and duplicated destination
in the Share form bullets.
Residual Mautic.FeatureList suggestions on 'form' (the Share form) and the
bold **Publish** button label are accepted false positives on correct UI
terminology per the Mautic style guide.
|
Thanks, @adiati98 — the Vale warnings on the changed lines are addressed and pushed to this PR.
Two Vale suggestions (non-failing) intentionally remain, and I want to flag them rather than silently suppress them:
Per the style guide those substitutions apply only to the actual features, so keeping the accurate UI terms is correct here. If you'd rather have them silenced, the repo's convention would be a block-level |
adiati98
left a comment
There was a problem hiding this comment.
@promptless-for-oss please address the suggestions.
|
Thanks, @adiati98 — on it. We'll investigate the mautic/mautic source behind the Share form to confirm the correct term for the flagged line (docs/campaigns/exporting_campaigns.rst:58), fix the Vale warning accordingly, and address the other review suggestions. We'll follow up here once the fixes are pushed. |
|
Update: we confirmed against the mautic/mautic source (PR #15904) that the Share form's submit button is literally labeled Publish to Marketplace, so Publish is the accurate term for the flagged line. The Vale finding is a false positive — the rule maps the activate/deactivate sense of "publish" to Active/Turn On, which doesn't apply to a button named Publish to Marketplace. We're finalizing the fix on the branch and will follow up once pushed. |
…arning Address @adiati98's review on PR mautic#939: the Campaign Share form's submit button is literally 'Publish to Marketplace' (mautic.campaign.share.publish), not the bare 'Publish' that tripped the Mautic.FeatureList Vale rule. Use the code-accurate label and fence the button-label bullets with .. vale off/on so the entity activate/deactivate substitution no longer misfires on the button proper-name.
|
Thanks for the review, @adiati98. We confirmed the button labels against the Mautic 7.x source (PR #15904): the Campaign Share form's actions are Publish to Marketplace and Download ZIP, so we've updated the page to use the exact Publish to Marketplace label rather than the bare word "Publish". Because that label is the button's own name (not the entity-activation sense the linter checks for), we fenced those two action bullets with the docs' standard |
|
Thanks for the detailed review, @vukovicpredrag — verifying the three corrections (standalone primary button vs. context menu, the |
|
Thanks, @vukovicpredrag — folding in the second batch too: the fifth required field (headline), the UI label names (Name, Vendor Name, Package Version), the 100-character description minimum, and the additional form fields (Keywords, Works with, Languages, Banner Image plus a Gallery of up to 5 images with ALT text). All corrections are going onto this branch. |
|
Verified both reviews against the 7.x source and all corrections check out — Rate & Review is a standalone primary button (not a context-menu item) that opens the package's own page in a new tab, and the Share form has five required fields (Name, Vendor Name, Package Version, Headline, Description) plus the Keywords / Works with / Languages / image-gallery details. Applying the edits to this branch now. One thing surfaced along the way: the gallery is described as "up to 5" in the reviewer note and in-product help text, but the 7.x form/template code builds 8 slots with no max constraint — a code/help-text mismatch in the product itself. We'll document the user-facing behavior conservatively; flagging it in case it's worth a product-side look. |
|
Left two review comments with corrections against the 7.x source. @promptless-for-oss those need a push before this lands in 7.2. |
…hare fields - marketplace.rst: Rate & Review is a standalone star-icon button on the Plugin detail page (not a context-menu item); opens the Plugin's own page on the Marketplace website in a new browser tab - exporting_campaigns.rst: correct Publish to Marketplace to five required fields (Name, Vendor Name, Package Version, Headline, Description) with constraints, optional fields, and image handling Addresses reviews by @vukovicpredrag on PR mautic#939, verified against mautic/mautic 7.x.
|
I noticed that some CI checks failed for this PR. I'm investigating whether the failures are caused by this suggestion. If they're unrelated or pre-existing, I'll leave this suggestion unchanged and create a separate suggestion if a standalone docs fix is needed. |
|
Pushed (SHA Rate & Review ( Publish to Marketplace ( One note on the red build check: it's not from this branch. It fails at the checklinks step on pre-existing parse errors in files this PR doesn't touch ( |
Open in Promptless
Documents the user-facing Marketplace changes introduced in mautic/mautic PR #15904 ("New Marketplace API, review, rating (public-marketplace)"), merged to
7.x. Targets the 7.2 docs branch.Changes
docs/marketplace/marketplace.rst
docs/campaigns/exporting_campaigns.rst
mauticreserved, Package Version a valid semantic version). Optional fields: Keywords, Works with (at least one Mautic version required to publish), and Languages, plus a Banner Image and an image gallery with per-image alt text.docs/links/marketplace_mautic_org.py
Review feedback applied (@vukovicpredrag, verified against mautic/mautic 7.x)
Two reviews on this PR were folded in. Disposition per item:
Review 1 — Rate & Review:
'primary': trueinPackage/detail.html.twig.)target="_blank", URL/package/{vendor}/{name}).marketplace-api.mautic.org; the docs only ever referencedmarketplace.mautic.orgvia the xref, which is already correct. (Confirmed:MARKETPLACE_WEBSITE_URLandMARKETPLACE_REGISTRY_URLbothhttps://marketplace.mautic.org.)Review 2 — Campaign Share form:
CampaignShareTypeNotBlankon title/vendorName/version/headline/description).CampaignShareTypeloop1..8;share_form.twig{% for i in 1..8 %}). Given that code/help-text mismatch, the docs avoid committing to a number. Flagging for maintainers to reconcile the help text with the code.Notes
Generated by Promptless.