Skip to content

fix: use sonic.Unmarshal instead of json.Unmarshal for embedding string decoding #7790

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
sammaji wants to merge 1 commit into from
Closed

fix: use sonic.Unmarshal instead of json.Unmarshal for embedding string decoding #7790

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion plugins/semanticcache/search.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@ import (
"strings"
"time"

"github.com/bytedance/sonic"
"github.com/cespare/xxhash/v2"
"github.com/google/uuid"
bifrost "github.com/maximhq/bifrost/core"
Expand Down Expand Up @@ -177,7 +178,7 @@ func (plugin *Plugin) generateEmbedding(ctx *schemas.BifrostContext, text string
switch {
case embedding.EmbeddingStr != nil:
var vals []float32
if err := json.Unmarshal([]byte(*embedding.EmbeddingStr), &vals); err == nil {
if err := sonic.Unmarshal([]byte(*embedding.EmbeddingStr), &vals); err == nil {
Comment thread
sammaji marked this conversation as resolved.
return vals, inputTokens, nil
}
// encoding_format=base64 packs little-endian float32s rather than a JSON array.
Expand Down
Loading