Skip to content

Lb/update languages menu ux behind flag - #3335

Merged
lilybarrett merged 14 commits into
mainfrom
lb/update-languages-menu-UX-behind-flag
Jul 27, 2026
Merged

lilybarrett merged 14 commits into
mainfrom
lb/update-languages-menu-UX-behind-flag

Conversation

@lilybarrett

@lilybarrett lilybarrett commented Jul 13, 2026 •

Copy link
Copy Markdown
Contributor

Scope

We want to redesign the header with a two-tier menu that, among other things, reimagines what the Languages button/menu looks like. This adds that redesign behind the feature flag that also enables Smartling translations .

Asana Ticket:
https://app.asana.com/1/15492006741476/project/1213994587940653/task/1216081563934501?focus=true

Implementation

  • Please note that this adds some changes to the Typescript code that handles interactions w/ the headers/menus on Dotcom -- namely to allow Dotcom to handle multiple tiers of headers rather than just one.
  • Additional CSS classes and design updates behind the feature flag -- You may notice some code duplication here.
  • Some minor code refactors

Screenshots

Screenshot 2026-07-14 at 4 35 32 PM

How to test

  • Pull down this branch or navigate to the deployment branch
  • Ensure nothing in the header UX/functionality looks broken (BEFORE turning on the feature flag)
  • Navigate to /_flags and turn on the feature flag
  • Interact with the new two-tiered header -- ensuring that buttons/links on both menu tiers still work as expected, changing the screen size, etc.
  • Turn on Voiceover and tab around, ensuring that the Languages button adheres to accessibility expectations. (It should behave similarly to the existing buttons on the menu).

Note: Changes to the footer will come in future work, once designs are complete.

@lilybarrett
lilybarrett force-pushed the lb/update-languages-menu-UX-behind-flag branch 4 times, most recently from 0b1dc58 to a743b3c Compare July 15, 2026 14:46
Comment thread assets/css/_global-navigation.scss
Comment thread assets/css/_header.scss
@lilybarrett
lilybarrett force-pushed the lb/update-languages-menu-UX-behind-flag branch 3 times, most recently from dba6265 to f9ceaec Compare July 15, 2026 20:07
Comment thread assets/ts/app/global-navigation.ts
@lilybarrett
lilybarrett marked this pull request as ready for review July 15, 2026 20:27
@lilybarrett
lilybarrett requested a review from a team as a code owner July 15, 2026 20:27
@lilybarrett
lilybarrett requested a review from joshlarson July 15, 2026 20:27
@smartling-github-connector smartling-github-connector Bot added the Not Ready for Translation Remove this when the PR is approved to trigger a Smartling translation job label Jul 15, 2026
@lilybarrett
lilybarrett requested a review from thecristen July 15, 2026 20:27
@thecristen thecristen added the dev-blue Deploy to dev-blue label Jul 16, 2026
@lilybarrett
lilybarrett force-pushed the lb/update-languages-menu-UX-behind-flag branch from f9ceaec to f982f18 Compare July 16, 2026 20:25
thecristen

This comment was marked as resolved.

Lily Barrett Lily Barrett
WIP
Style new header properly
Lily Barrett and others added 8 commits July 22, 2026 13:34
Manually resolve merge conflict

Remove unnecessary comments

Only make necessary changes

Bring code back in that got deleted by accident

Restore previous behaviors

More styling tweaks
Co-authored-by: Cristen Jones <cjones3@mbta.com>
Update margin values

Minor cleanup

Run prettier
@lilybarrett
lilybarrett force-pushed the lb/update-languages-menu-UX-behind-flag branch from 5bf0f13 to abe2f77 Compare July 22, 2026 17:35
@lilybarrett
lilybarrett force-pushed the lb/update-languages-menu-UX-behind-flag branch from c8d3764 to 50b22ce Compare July 24, 2026 17:14
@lilybarrett lilybarrett removed the Not Ready for Translation Remove this when the PR is approved to trigger a Smartling translation job label Jul 24, 2026
Comment thread lib/dotcom_web/templates/layout/_new_header.html.heex Outdated
Lily Barrett added 2 commits July 27, 2026 13:01
Fix languages order

Add max-width to search bar

Tweak padding
@lilybarrett
lilybarrett force-pushed the lb/update-languages-menu-UX-behind-flag branch from 06eadbd to 00319d2 Compare July 27, 2026 17:02

@thecristen thecristen left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉 Thanks!!

@thecristen thecristen removed the dev-blue Deploy to dev-blue label Jul 27, 2026
@lilybarrett
lilybarrett merged commit f4cae04 into main Jul 27, 2026
23 checks passed
@lilybarrett
lilybarrett deleted the lb/update-languages-menu-UX-behind-flag branch July 27, 2026 18:00

This branch was previously deployed

1 inactive deployment
dev-blue — 450c5a16 Deployed Jul 27, 2026 by lilybarrett via pr / Deploy to dev-blue #5652
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants