feat: Show wall-clock time for ferry trips on stop pages - #3482
Merged
Conversation
joshlarson
enabled auto-merge (squash)
September 8, 2026 22:10
joshlarson
disabled auto-merge
September 8, 2026 22:10
joshlarson
changed the title
joshlarson
enabled auto-merge (squash)
September 8, 2026 22:10
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Scope
Asana Ticket: ⛴️ Ferry stop pages follow realtime consistency guidelines
Implementation
Note
🤖 There are four commits here, each generated by Copilot.
isCRto be true for commuter rail and ferry trips.isCRtorenderAbsoluteTime, since it doesn't really make sense to have a variable calledisCRthat's true for trips that aren't commuter rail trips.renderAbsoluteTimewas being used to determine track number rendering, so I asked Copilot to restore the previousisCR, and use it for that and only that.renderAbsoluteTimemakes more sense in Elixir, where you can name a function likerender_absolute_time?. In Javascript, it's more customary to name functions likeshouldRenderAbsoluteTime, and so that's what this commit does.Screenshots
How to test
Go to a ferry dock page, and admire the wall-clock display. Click around inside the departures box - there's a lot to see in there!