Skip to content

Antisymmetry BC with surface-piercing topology - #287

Draft
gawng wants to merge 28 commits into
mdolab:mainfrom
gawng:fsbc-SPfix
Draft

Antisymmetry BC with surface-piercing topology#287
gawng wants to merge 28 commits into
mdolab:mainfrom
gawng:fsbc-SPfix

Conversation

@gawng

@gawng gawng commented Jun 9, 2023

Copy link
Copy Markdown
Collaborator

Purpose

This needs more test cases before it is ready for merging.

The antisymmetry BC is appropriate for high-speed foils near the free surface for modelling the loss of lift and increase in drag. This PR contains the antisymmetry option that works for surface-piercing topology (e.g., a strut).

Expected time until merged

Summer 2024

Type of change

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (non-backwards-compatible fix or feature)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Documentation update
  • Maintenance update
  • Other (please describe)

Testing

Checklist

  • I have run flake8 and black to make sure the Python code adheres to PEP-8 and is consistently formatted
  • I have formatted the Fortran code with fprettify or C/C++ code with clang-format as applicable
  • I have run unit and regression tests which pass locally with my changes
  • I have added new tests that prove my fix is effective or that my feature works
  • I have added necessary documentation

@codecov

codecov Bot commented Jun 9, 2023

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 27.57%. Comparing base (20ff867) to head (5a52fd0).
⚠️ Report is 20 commits behind head on main.

❗ There is a different number of reports uploaded between BASE (20ff867) and HEAD (5a52fd0). Click for more details.

HEAD has 4 uploads less than BASE
Flag BASE (20ff867) HEAD (5a52fd0)
8 4
Additional details and impacted files
@@             Coverage Diff             @@
##             main     #287       +/-   ##
===========================================
- Coverage   41.02%   27.57%   -13.45%     
===========================================
  Files          13       13               
  Lines        4119     4119               
===========================================
- Hits         1690     1136      -554     
- Misses       2429     2983      +554     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants