Repository navigation
Conversation
|
🎉 This PR is included in version 4.3.3 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Respect each explicitly allowed heading level in Markdown shortcuts. With
allowedHeadingLevels: [2, 4], typing###currently creates an h3 because the transformer matches the entire min/max range.This addresses the remaining nonconsecutive-level behavior after #952.
Regression evidence
On unchanged main (
122347c), the Lexical shortcut test with[2, 4]fails after inserting a space after###: the resulting node isheading, but should remainparagraph. The other five heading-level cases pass. All six pass with this change.The focused suite also checks default, contiguous, nonconsecutive, unsorted, repeated, single-level, and empty configurations, including the marker capture used for the resulting heading level.
Verification
Passed locally:
npm run lintnpm run typechecknpm run test:once: 154 passed, 1 skipped, 1 todonpm run test:lexical-versions: 24 packages at 0.48.0npm run buildnpm run build:docs:apinpm exec ladle -- build: all examples builtgit diff --checkThe local environment could not install/start the matched browsers. The unchanged existing workflow has now completed on the fork for this exact head (
5d9ca7d3b1ceb093f855bc2c4a4238eb3f6cd15d): CI run.0.35 input → packed 0.48 output → published 4.0.4/0.35 reader) passed.This fork validation is separate from upstream CI approval. The PR remains draft.