fix(release): formatter-stable changelog spacing; drop the environment gate - #22
Merged
Merged
Conversation
…t gate The changelog writer left a double newline at EOF, which dprint strips — so the first back-merge PR failed its consumer's fmt-check. Normalise to one blank line between blocks and one newline at EOF. Merging the settle PR is the release approval (the release-* ruleset requires a reviewed PR), so the publish template no longer runs under a release environment; repos wanting a second approver can add one. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013eLFMaDpEwgDzyDBzCQzLH
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two things learned from the mega-agents pilot:
insert_changelog_sectionleft a double newline at EOF; dprint strips it, so the first back-merge PR (mega-agents#293) failed its consumer'sfmt-check. The writer now normalises to one blank line between blocks and one newline at EOF, which is stable under dprint/prettier. Test added (13 pass).release-*ruleset requires a reviewed PR — so the second approval on the publish job was redundant. The template dropsenvironment: release; the README says a repo can add one if it wants a separate second approver.🤖 Generated with Claude Code