Repository navigation
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When a downstream crate specifies a semver-compatible requirement such as
salt = "1.0.5"and exhaustively matches the publicSaltErrorenum, Cargo may upgrade it to 1.0.6, but compilation will then fail because this release addsSaltError::UnchainedTransitionto an enum that is not marked#[non_exhaustive]. Publish these changes under a breaking version, or avoid extending the exhaustive public enum, so a nominally compatible patch update cannot break downstream builds.Useful? React with 👍 / 👎.