Skip to content

ci(release): rely on the release environment alone (settlers: any) - #154

Merged
Troublor merged 1 commit into
mainfrom
troublor/ci/settlers-any
Sep 9, 2026
Merged

Troublor merged 1 commit into
mainfrom
troublor/ci/settlers-any

Conversation

@Troublor

@Troublor Troublor commented Sep 9, 2026

Copy link
Copy Markdown
Collaborator

Drops settlers: admin from release-settle.yml: the release environment's required reviewers are the release gate, and the extra check that the dispatcher is a repository admin duplicated it. The shared action now defaults settlers to any (megaeth-labs/.github#42), so leaving it unset means "the environment alone". Header comment updated. Merge after megaeth-labs/.github#42; before that, an unset settlers fails direct mode.

🤖 Generated with Claude Code

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 9, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-09-09T11:00:46.131958Z 5fec733 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@github-actions

github-actions Bot commented Sep 9, 2026

Copy link
Copy Markdown

Mutation testing - PASS

Nothing to test: no viable mutants were generated.

The environment's required reviewers are the release gate; the extra
admin check on the dispatcher duplicated it and is dropped now that the
shared action defaults settlers to any.

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
@github-actions

github-actions Bot commented Sep 9, 2026

Copy link
Copy Markdown

Mutation testing - PASS

Nothing to test: no viable mutants were generated.

@github-actions

github-actions Bot commented Sep 9, 2026

Copy link
Copy Markdown

Performance Benchmark Comparison

Compared 5 benchmark(s) against the latest main baseline.

Detailed Comparison
Benchmark Baseline Throughput (Kelem/s) New Throughput (Kelem/s) Change
update 10000 KVs/1 threads 77.36 74.43 -3.79%
update 10000 KVs/2 threads 144.70 140.63 -2.81%
update 10000 KVs/4 threads 274.20 257.86 -5.96%
update 10000 KVs/8 threads 460.79 432.02 -6.24%
update 10000 KVs/16 threads 614.41 572.44 -6.83%

@Troublor
Troublor merged commit 4135b55 into main Sep 9, 2026
16 checks passed
@Troublor
Troublor deleted the troublor/ci/settlers-any branch September 9, 2026 11:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant