ci(release): accept a base_commit on the release candidate - #155
Merged
Merged
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Mutation testing - PASSNothing to test: no viable mutants were generated. |
release-candidate now takes a base_commit, to release a commit that is not the tip of the default branch. A workflow_dispatch input must be declared per workflow before it can be passed, so the feature is not dispatchable here until this lands. Blank is today's behaviour unchanged. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Mutation testing - PASSNothing to test: no viable mutants were generated. |
Performance Benchmark ComparisonCompared Detailed Comparison
|
The header still said the cut job always creates the release branch at the merge commit. With base_commit, propose creates it at the named commit and cut does not run at all, so an operator reading only the header would be misled about which branch the candidate PR touches. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
release-candidategained abase_commitinput inmegaeth-labs/.github, for releasing a commit that is not the tip of the default branch. Aworkflow_dispatchinput has to be declared in each workflow before it can be passed, so without this the feature cannot be dispatched here at all.Two additions, matching the updated
workflow-templates/release-candidate.yml:base_commitdispatch input, optional and blank by default;proposestep.Blank keeps today's behaviour exactly: the candidate PR goes to the default branch and the
cutjob creates the release branch at the merge commit. Given a commit,proposecutsrelease-vX.Y.Zat that commit and aims the candidate PR at it, so the default branch is untouched andcutdoes not run.The commit must be reachable from the default branch. Note that
v*tags are not, because settlement commits the dated changelog on the release branch. Full guide:megaeth-labs/.github/.github/actions/RELEASE.md, section "Releasing a commit that is not the tip".actionlintclean.🤖 Generated with Claude Code