Addresses #3/#26, fixes dependencies - #36
Open
JohnnyStreet wants to merge 2 commits into
Open
Conversation
Update hidiffusion.py
|
I just came here to drop a line that this PR would indeed fix the errors: I just applied this patch manually to the file in the conda lib to test it a couple of weeks ago, and it worked so well I forget that I had done that until last night when I started a new conda env and forgot about this fix and my app broke completely. Took me two hours to remember that I had applied some patch at some point, so commenting here now to leave breadcrumbs for future me until this gets merged in. Thank you @JohnnyStreet for this fix, and @ShenZhang-Shin and team for this library. My main usecase for it is to keep memory consumption under control for SDXL models on a mac, and without hidiffusion I would not be able to build my app. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This addresses #3 and #26 by implementing vladmandic's suggestion for detecting inpainting (#3 (comment)), and by adding an optional parameter to support playground models.
It also addresses several typos and missing dependencies, and removes unused dependencies.