Blocks API: CUDA support - #1592
Closed
NicolasHug wants to merge 1 commit into
Closed
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/meta-pytorch/torchcodec/1592
Note: Links to docs will display an error until the docs builds have been completed. ✅ You can merge normally! (1 Unrelated Failure)As of commit e3c66fb with merge base 3f7692b ( FLAKY - The following job failed but was likely due to flakiness present on trunk:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
meta-cla
Bot
added
the
CLA Signed
NicolasHug
commented
Jul 31, 2026
| results = {} | ||
| for name, fn in methods.items(): | ||
| times_ns, cpu = bench(fn, path) | ||
| times_ns, cpu = bench(fn, path, args.device) |
Contributor
Author
There was a problem hiding this comment.
needs a cuda sync somewhere
NicolasHug
commented
Aug 1, 2026
| int64_t even_height = round_up_to_even(av_frame->height); | ||
| int64_t num_bytes = pitch * even_height * 3 / 2; | ||
|
|
||
| cudaStream_t stream = get_current_cuda_stream(device_.index()); |
Contributor
Author
There was a problem hiding this comment.
shouldn't we wait on info->producing_stream (which i think is the nvdec_stream) before starting the copy?
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.