Fix stale weather temp — fetch independently of weather card#582
Merged
Conversation
The weather summary next to the date was reading from localStorage but only the weather card ever wrote to it. Since we removed the card, the cached value was frozen at whatever it was last time the card rendered. Now the date-line weather script runs its own fetch cycle: 1. Show cached value immediately (no flash of empty) 2. If cache is older than 1 hour, fetch fresh data from /weather 3. Uses the same lat/lon localStorage keys the card used 4. If no cached location, requests geolocation (same as card did) 5. Updates localStorage and the displayed temp on success Works whether or not the weather card is visible. The card and the date-line share the lat/lon keys but the summary has its own cache key (mu_weather_now + mu_weather_now_ts) so they don't conflict.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The weather summary next to the date was reading from localStorage but only the weather card ever wrote to it. Since we removed the card, the cached value was frozen at whatever it was last time the card rendered.
Now the date-line weather script runs its own fetch cycle:
Works whether or not the weather card is visible. The card and the date-line share the lat/lon keys but the summary has its own cache key (mu_weather_now + mu_weather_now_ts) so they don't conflict.