[live-migration] replace event/error strings with structured MigrationNotification#2697
Merged
rawahars merged 4 commits intomicrosoft:mainfrom Apr 22, 2026
Merged
Conversation
…fication
Drop the free-form `event` and `error` string fields on
TransferSandboxResponse in favor of a structured `MigrationNotification`
message that mirrors the HCS OperationSystemMigrationNotificationInfo
payload.
The new MigrationNotification carries:
- MigrationOrigin: source vs. destination side of the migration
- MigrationEvent: lifecycle event (setup done, blackout started/exited,
transfer in progress, migration done/failed, recovery done, ...)
- MigrationResult: terminal outcome (success, cancelled, guest-initiated
cancellation, source/destination failure, recovery failure)
- AdditionalDetails: google.protobuf.Any for event-specific data
Signed-off-by: Harsh Rawat <[email protected]>
apurv15
approved these changes
Apr 21, 2026
jterry75
reviewed
Apr 21, 2026
jterry75
approved these changes
Apr 21, 2026
Signed-off-by: Harsh Rawat <[email protected]>
Signed-off-by: Harsh Rawat <[email protected]>
jterry75
reviewed
Apr 22, 2026
| MemoryTransport memory_transport = 1; | ||
| // MemoryTransferThrottleParams specifies settings for throttling during memory transfer. | ||
| optional MemoryMigrationTransferThrottleParams memory_transfer_throttle_params = 2; | ||
| optional MemoryTransferThrottleParams memory_transfer_throttle_params = 2; |
Contributor
There was a problem hiding this comment.
It's perfectly fine to write 'optional' in front of a message type but just FYI all message types are optional
Signed-off-by: Harsh Rawat <[email protected]>
jterry75
approved these changes
Apr 22, 2026
apurv15
approved these changes
Apr 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Drop the free-form
eventanderrorstring fields on TransferSandboxResponse in favor of a structuredMigrationNotificationmessage that mirrors the HCS OperationSystemMigrationNotificationInfo payload.The new MigrationNotification carries: