fix(dashboard): use newline-delimited messages instead of half-open sockets#40298
Open
pavelfeldman wants to merge 1 commit intomicrosoft:mainfrom
Open
fix(dashboard): use newline-delimited messages instead of half-open sockets#40298pavelfeldman wants to merge 1 commit intomicrosoft:mainfrom
pavelfeldman wants to merge 1 commit intomicrosoft:mainfrom
Conversation
…ockets Windows named pipes don't support half-open connections, so `socket.end(data)` from the client would kill the pipe before the server could write back. Switch to newline-delimited framing where the server always initiates socket closure.
Contributor
Test results for "MCP"2 failed 6419 passed, 976 skipped Merge workflow run. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
socket.end(data)from the client kills the pipe before the server can write back, causingshow --annotateto exit immediately