scripts: Add incremental mode to get_auth_var_signing_certificate.py - #470
Merged
Doug Flick (Flickdm) merged 1 commit intoSep 9, 2026
Conversation
Doug Flick (Flickdm)
enabled auto-merge (rebase)
September 8, 2026 20:38
SochiOgbuanya
approved these changes
Sep 8, 2026
SochiOgbuanya
left a comment
SochiOgbuanya
left a comment
Collaborator
There was a problem hiding this comment.
You still have one failing check
Modify the get_auth_var_signing_certificate.py script to support two modes for updating kek_update_map.json: 1. Incremental Mode (default): - Loads existing kek_update_map.json - Processes only NEW .bin files not already in the map - Preserves existing entry order - Minimal diffs when adding new KEK updates 2. Sort Mode (--sort flag): - Processes all .bin files - Sorts entries alphabetically by KEKUpdate path - Useful for one-time cleanup of main branch Changes: - process_directory() now accepts sort_output parameter (default: False) - Added --sort/-s flag to CLI argument parser - Incremental mode loads and merges with existing map - Existing entries are skipped when already present (by SHA1 hash key) Benefits: - PR diffs now show only new entries (~10 lines instead of 138) - Easier code review of KEK update contributions - Maintains alphabetical ordering expectations - Backward compatible (default behavior is incremental) Signed-off-by: Doug Flick <dougflick@microsoft.com>
Doug Flick (Flickdm)
force-pushed
the
support/kek_update_map/incremental_updates
branch
from
September 8, 2026 22:19
8731091 to
8be435d
Compare
olkorsha
approved these changes
Sep 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Modify the get_auth_var_signing_certificate.py script to support two modes for updating kek_update_map.json:
Incremental Mode (default):
Sort Mode (--sort flag):
Changes:
Benefits:
For details on how to complete these options and their meaning refer to CONTRIBUTING.md.
How This Was Tested
Locally with Test CAs
Integration Instructions
N/A