Enable hide/show of type size/alignment

[Colen Garoutte-Carson (Colengms)]

The recently added type size and alignment details are useful, but they make every eligible C++ hover larger. This adds a default-on, resource-scoped setting for hiding those fields and a Command Palette action that users can bind to a key. The extension deliberately does not claim a default keyboard shortcut.

Fixes #14820

[Copilot]

🟡 Changes recommended

Setting changes confined to a non-default workspace folder do not notify the language server.

2 open findings

• Workspace setting changes do not notify the language server · New
• Hover toggle tests do not verify details hide and restore · New

What changed in this PR

Adds configurable visibility for type size and alignment in IntelliSense hovers, addressing #14820.

Changes:

• Adds a default-on, resource-scoped setting and forwards it to the language server.
• Adds a Command Palette toggle without a default keyboard shortcut.
• Adds configuration and command tests.

File	Description
Extension/​test/​scenarios/​MultirootDeadlockTest/​tests/​quickInfo.test.ts	Tests setting values and command toggling.
Extension/​src/​LanguageServer/​settings.ts	Exposes the setting and makes updates awaitable.
Extension/​src/​LanguageServer/​extension.ts	Registers and implements the toggle command.
Extension/​src/​LanguageServer/​client.ts	Includes the setting in server configuration.
Extension/​package.nls.json	Adds setting and command text.
Extension/​package.json	Declares the setting and command contributions.

🧠 Review effort: Balanced

---

Give feedback about Copilot approvals in this survey to enter a drawing for a $150 gift card.

[Copilot]

🟡 Changes recommended

Cached hover content can prevent visibility changes from appearing when reopening the same hover.

1 open finding

• Verify both labels toggle visibility · New

2 resolved since last review

• Hover toggle tests do not verify details hide and restore
• Workspace setting changes do not notify the language server

Previously missed (1)

In code that hasn't changed since last review

Reset hover state when settings change

Extension/​src/​LanguageServer/​extension.ts:305

With Copilot hovers enabled and a chat model available, toggling this setting and reopening the hover at the same position can still show the old details. HoverProvider.ts:24–26 returns lastContent when CopilotHoverProvider.isNewHover() is false, bypassing the server even after its settings are updated. Reset the default client's Copilot hover state when this setting changes so the next hover requests fresh content.

🧠 Review effort: Balanced

[Copilot]

🔵 Needs a closer look

Cached same-position hovers can retain the previous size/alignment visibility after toggling.

0 open findings

1 resolved since last review

• Verify both labels toggle visibility

Previously missed (1)

In code that hasn't changed since last review

Reset Copilot hover cache when hover settings change

Extension/​src/​LanguageServer/​extension.ts:305

With Copilot hovers enabled and a model available, hovering a type, toggling this setting, and hovering the same position again returns the previous size/alignment visibility. HoverProvider.ts:24–26 reuses cached content when CopilotHoverProvider reports the same document and position; sending settings does not invalidate that cache. After sending the updated settings, reset the default client's Copilot hover provider when this option changes so the next hover requests fresh content. Handle this in the settings-change dispatcher to cover both command toggles and direct settings edits.

🧠 Review effort: Balanced

[Colen Garoutte-Carson (Colengms)]

Addressed the latest Copilot review note. Changing type size and alignment visibility now invalidates the same-position Copilot hover cache, so the next hover reflects the new setting.

Written by Copilot

[Copilot]

🟡 Changes recommended

The changed update return type introduces existing floating promises that violate the extension’s ESLint configuration.

1 open finding

• Await newly async calls to prevent floating promise lint errors · New

🧠 Review effort: Balanced

[Copilot]

🟢 Approval recommended

The setting, command, multi-root propagation, cache invalidation, and behavioral coverage are complete and consistent.

0 open findings

1 resolved since last review

• Await newly async calls to prevent floating promise lint errors

🧠 Review effort: Balanced