Conversation
…ion) A held job stays PENDING, so `submit` returns as soon as it's the only pending job: this exercises the real sync + sbatch path without waiting for resources, so it can run in the self-hosted CI unlike `test_submit`. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #224 +/- ##
===========================================
+ Coverage 72.10% 87.42% +15.31%
===========================================
Files 22 22
Lines 2370 2370
===========================================
+ Hits 1709 2072 +363
+ Misses 661 298 -363 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The existing real-cluster
test_submitis skipped in CI (it waits for the job to actually run), so the real sync →sbatchpath ofcluv submithas no coverage on Codecov.This adds two integration tests that exercise that path in seconds:
test_submit_held_job: submitsscripts/job.shwith--hold. A held job staysPENDING, sosubmitreturns as soon as it sees it's the only pending job (no waiting for resources). Checks that aJobis returned andsacctreportsPENDING, thenscancels it.test_submit_rejected_by_sbatch: submits with--partition=cluv-does-not-existand checks thatsubmitreturnsNonewhensbatchrejects the job.Both follow
test_submit's conventions (slowmarker, xfail on clusters outsideSUBMIT_SUPPORTED_CLUSTERS). In the self-hosted CI they'll run onmila;tamiaxfails.Tested locally: 4 passed (mila + rorqual) in ~2 min, no held jobs left in the queue.
🤖 Generated with Claude Code