Bucket versioning#183
Draft
krisis wants to merge 2 commits into
Draft
Conversation
donatello
requested changes
Nov 4, 2022
|
|
||
| newtype MFAToken = MFAToken {unMfaToken :: Text} | ||
| deriving stock (Eq, Show) | ||
| deriving (IsString) via Text |
Member
There was a problem hiding this comment.
mfatoken is just a text, so we can use newtype deriving here:
deriving stock (Show)
deriving newtype (Eq, IsString)
Member
There was a problem hiding this comment.
Actually looks like MFAToken is just a sort of Boolean - https://docs.aws.amazon.com/AmazonS3/latest/API/API_GetBucketVersioning.html
we can just do:
data MFADelete = MFADeleteEnabled | MFADeleteDisabled
donatello
requested changes
Nov 4, 2022
|
|
||
| newtype MFAToken = MFAToken {unMfaToken :: Text} | ||
| deriving stock (Eq, Show) | ||
| deriving (IsString) via Text |
Member
There was a problem hiding this comment.
Actually looks like MFAToken is just a sort of Boolean - https://docs.aws.amazon.com/AmazonS3/latest/API/API_GetBucketVersioning.html
we can just do:
data MFADelete = MFADeleteEnabled | MFADeleteDisabled|
|
||
| data BucketVersioningConfig = BVConfig | ||
| { vcVersioning :: BucketVersioning, | ||
| vcMFADelete :: MFADelete |
Member
There was a problem hiding this comment.
Suggested change
| vcMFADelete :: MFADelete | |
| vcMFADelete :: Maybe MFADelete |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.