Feat/xmorse

[riemannulus]

No description provided.

[Copilot]

Pull Request Overview

This PR introduces cross-chain NFT transfer functionality for the xMorse protocol, enabling NFT bridging between Ethereum and Mitosis chains using Hyperlane infrastructure.

Key changes:

• Added xMorseCollateral contract for locking NFTs on the source chain (Ethereum)
• Modified xMorse initialization to support external treasury setup
• Implemented comprehensive test coverage for cross-chain transfers and collateral operations

Reviewed Changes

Copilot reviewed 10 out of 10 changed files in this pull request and generated 2 comments.

Show a summary per file

File	Description
test/xMorseCollateral.t.sol	Unit tests for collateral contract covering NFT locking, transfers, and ownership
test/xMorse.t.sol	Unit tests for xMorse token including initialization, finalization, and DN404 functionality
test/xDN404Treasury.t.sol	Fixed treasury initialization to set skipNFT before token transfer
test/utils/HyperlaneTestUtils.sol	Added hook fee configuration and improved documentation for message relay
test/libs/LibTransfer.t.sol	Updated revert testing to use try-catch pattern for library calls
test/integration/CrossChainTransfer.t.sol	Integration tests for end-to-end cross-chain transfers (marked as skipped pending MockMailbox)
src/xMorseCollateral.sol	Implements collateral contract with correct mirror NFT contract handling
src/xMorse.sol	Modified initialization flow to support external treasury setup and fixed NFT fetching
src/xDN404Treasury.sol	Removed automatic skipNFT setting from constructor
src/libs/LibTransfer.sol	Fixed operator precedence in multicall array size calculation

---

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

[Copilot]

The comment 'For type casting only' is misleading since xDN404Treasury is no longer instantiated in this contract but the import is still used for type information. Consider updating to 'For type reference' or 'For type information' to be more accurate.

Suggested change

	import { xDN404Treasury } from './xDN404Treasury.sol'; // For type casting only
	import { xDN404Treasury } from './xDN404Treasury.sol'; // For type reference

[Copilot]

Using the same error TreasuryAlreadySet() for two different conditions (not initializing vs treasury already set) makes debugging difficult. The first check should use a different error like NotInInitializationPhase() to distinguish between these failure cases.

Suggested change

	constructor(address _mailbox) xDN404Base(_mailbox) { }
	/// @notice Set treasury address (only callable once during initialization phase)
	function setTreasury(address _treasury) external onlyOwner {
	StorageV1 storage $ = _getStorageV1();
	require($.initializing, TreasuryAlreadySet());
	error NotInInitializationPhase();
	constructor(address _mailbox) xDN404Base(_mailbox) { }
	/// @notice Set treasury address (only callable once during initialization phase)
	function setTreasury(address _treasury) external onlyOwner {
	StorageV1 storage $ = _getStorageV1();
	require($.initializing, NotInInitializationPhase());