fix: to_pyg no longer mutates the caller's input graph - #151
Open
BHUMIKA-VV wants to merge 1 commit into
Open
BHUMIKA-VV wants to merge 1 commit into
BHUMIKA-VV wants to merge 1 commit into
Conversation
`to_pyg` trimmed each node's attribute dict down to `node_features` by deleting keys in place on the graph passed in by the caller. Work on a copy instead, and add a regression test. Refs mllam#139
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your changes
to_pygtrimmed each node's attribute dict down tonode_featuresbydeleting keys directly on the graph object passed in by the caller — a
destructive side effect for what should be a read-only export function.
This works on a copy of the graph instead, so the caller's original graph
object is left untouched. Added a regression test
(
test_to_pyg_does_not_mutate_input_graph) that fails onmainandpasses with this fix.
Issue Link
Fixes #139
Type of change
Checklist before requesting a review