Skip to content

fix(e2e): use documented hide_error_dialogs ADB setting #359

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cursor merged 1 commit into from
Jun 30, 2026
Merged

fix(e2e): use documented hide_error_dialogs ADB setting #359

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions .github/workflows/e2e.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -205,11 +205,11 @@ jobs:
disable-animations: true
script: |
# Expo's heavier UI can trigger a system-level ANR dialog on the
# low-memory GitHub Actions emulator. Disable ANR prompts before
# installing the app so Maestro is not blocked by emulator noise.
adb shell settings put secure show_anr_messages 0
adb shell settings put global anr_dialogs_disabled true
adb shell settings put global anr_show_background false
# low-memory GitHub Actions emulator. hide_error_dialogs is the
# documented AOSP global setting (Settings.Global.HIDE_ERROR_DIALOGS)
# used by CTS/Input ANR tests to suppress error dialogs on API 29+.
# Maestro still dismisses any dialog that slips through (_setup.yaml).
adb shell settings put global hide_error_dialogs 1
Comment on lines +208 to +212

@devin-ai-integration devin-ai-integration Bot Jun 30, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚩 Narrower ANR suppression scope compared to the old approach

The old code set three separate settings (show_anr_messages, anr_dialogs_disabled, anr_show_background) which were informal/undocumented and may have targeted different dialog types. The new single setting hide_error_dialogs (Settings.Global.HIDE_ERROR_DIALOGS) is a documented AOSP flag that suppresses all error dialogs (ANR + crash), but it is a single coarse-grained flag rather than three fine-grained ones. In practice this should be equivalent or better for CI purposes, and the Maestro _setup.yaml:74-89 fallback loop that taps "Wait" on any visible ANR dialog provides a safety net. Worth confirming via a CI run that the Expo variant doesn't still see ANR dialogs slipping through, since the old settings were likely added in response to real flakiness.

Open in Devin Review

Was this helpful? React with 👍 or 👎 to provide feedback.

adb install ${{ matrix.dir }}/android/app/build/outputs/apk/release/app-release.apk
maestro test --env APP_ID="${{ matrix.bundle_id }}" .maestro/flows/ci-master.yaml

Expand Down