Error response form for native modules - #12
Open
yarsanukayev wants to merge 1 commit into
Open
yarsanukayev wants to merge 1 commit into
yarsanukayev wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
According to the BERT-RPC 1.0 spec error response should take the form of a tuple with two elements: an atom
errorand a tuple with five elements with error details, so I've corrected the appropriate code for native modules and tested if it works.This fix doesn't seem to affect something and works correctly with my BERT-RPC client providing it with the tuple consisting of the two elements: the atom and the tuple. Wireshark shows correct hex-encoded terms while they're being transmitted between interfaces.