Skip to content

docs: show custom keymaps in mail picker prompt title (#22)#23

Merged
monkeyxite merged 1 commit into
mainfrom
docs/22-mail-picker-title-hints
Jul 7, 2026
Merged

docs: show custom keymaps in mail picker prompt title (#22)#23
monkeyxite merged 1 commit into
mainfrom
docs/22-mail-picker-title-hints

Conversation

@monkeyxite

Copy link
Copy Markdown
Owner

Closes #22

Mirrors the pattern already used by the calendar picker in lua/nvim-mail/calendar.lua (line 169): embed the picker's hotkey hints directly in prompt_title so users can discover the mappings without reading the source or hunting for Telescope's <C-/> help popup.

Before

  Notmuch Search

After

  Notmuch  ·  C-r:reply-all  C-o:browser  C-t:tag  C-y:msgid  C-l:preview

No behavior change, cosmetic only. All existing telescope tests still pass.

Mirror the pattern already used by the calendar picker (calendar.lua line
169): embed the picker's hotkey hints directly in prompt_title so users
can discover the mappings without reading the source or hunting for
Telescope's <C-/> help popup.

No behavior change, cosmetic only.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the prompt title in the Telescope mail extension to display helpful keybinding shortcuts. Feedback suggests correcting the label for the C-r keybinding from reply-all to reply to accurately reflect its actual implementation and prevent user confusion.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.


pickers.new(opts, {
prompt_title = ' Notmuch Search',
prompt_title = ' Notmuch · C-r:reply-all C-o:browser C-t:tag C-y:msgid C-l:preview',

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The prompt title labels <C-r> as reply-all. However, looking at the implementation of the <C-r> mapping (lines 74-125), it only extracts the From header and populates the To field of the reply draft, without including other recipients (like Cc). Therefore, it functions as a standard reply rather than a reply-all. Labeling it as reply would be more accurate and prevent user confusion.

    prompt_title = '  Notmuch  ·  C-r:reply  C-o:browser  C-t:tag  C-y:msgid  C-l:preview',

@monkeyxite

Copy link
Copy Markdown
Owner Author

Bot noted that <C-r> on main is not reply-all — correct against main's current state. This label becomes accurate once #18 (reply-all feature) merges. Not fixing here; the label will be correct via merge order.

If #18 is closed instead of merged, this PR's label should switch back to C-r:reply.

@monkeyxite
monkeyxite merged commit 080d6fd into main Jul 7, 2026
2 checks passed
@monkeyxite
monkeyxite deleted the docs/22-mail-picker-title-hints branch July 7, 2026 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

docs/UX: Telescope mail picker doesn't advertise its custom keymaps; calendar picker already does

1 participant