Custom sessions & X-Session-UUID#1
Merged
Merged
Conversation
torotil
force-pushed
the
keep-session-uuid
branch
from
30a8929 to
792118a
Compare
torotil
force-pushed
the
keep-session-uuid
branch
from
792118a to
5e8e00d
Compare
katzmo
approved these changes
Jun 1, 2026
| org = flask.request.headers.get("x-ist-org", None) | ||
| return cls(None, {org: []} if org else {}) | ||
| headers = flask.request.headers | ||
| session_header = flask.current_app.config.get("AUTH_UUID_HEADER", "x-ist-session-uuid") |
There was a problem hiding this comment.
Following the naming scheme of the auth-wsgi-middleware, this should be called uuid_header. Also matches the setting better.
There was a problem hiding this comment.
Why are all the header names configurable, only the X-IST-org header is not? 🤔
Contributor
Author
There was a problem hiding this comment.
I think it should be too. But it wasn’t before. So I left it. Happy to make it configurable in a follow-up.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two changes:
Sessionrespects theX-Session-UUIDheader when creating anonymous sessions.