chore(engine-api): remove per-block debug timing logs#132
Conversation
The `new_l2_block engine timing` and `validate_l2_block timing` info logs fire once per imported block and flood stdout during live sync. They were added for debugging; per-block durations are already covered by the `new_l2_block_duration_seconds` and `validate_l2_block_duration_seconds` metrics.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
💤 Files with no reviewable changes (1)
📝 WalkthroughWalkthroughThis PR removes timing instrumentation from two block validation functions in the engine API builder. The ChangesTiming instrumentation cleanup
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~5 minutes Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Summary
new_l2_block engine timingandvalidate_l2_block timinginfo logs inmorph-engine-api, which fired once per imported block and flooded stdout during live sync (the node imports a block roughly every second).new_l2_block_duration_secondsandvalidate_l2_block_duration_secondsPrometheus metrics, and block import status is still visible via reth's ownBlock added to canonical chainlog.Instanttiming variables that only existed to feed these logs.Test plan
cargo check -p morph-engine-api -p morph-rethcargo clippy -p morph-engine-api --all-targets -- -D warningsSummary by CodeRabbit