Skip to content

chore(engine-api): remove per-block debug timing logs#132

Merged
chengwenxi merged 1 commit into
mainfrom
chore/remove-per-block-timing-logs
Jun 15, 2026
Merged

chore(engine-api): remove per-block debug timing logs#132
chengwenxi merged 1 commit into
mainfrom
chore/remove-per-block-timing-logs

Conversation

@panos-xyz

@panos-xyz panos-xyz commented Jun 12, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Remove the new_l2_block engine timing and validate_l2_block timing info logs in morph-engine-api, which fired once per imported block and flooded stdout during live sync (the node imports a block roughly every second).
  • These logs were added during early debugging; per-block durations are already covered by the new_l2_block_duration_seconds and validate_l2_block_duration_seconds Prometheus metrics, and block import status is still visible via reth's own Block added to canonical chain log.
  • Also drop the Instant timing variables that only existed to feed these logs.

Test plan

  • cargo check -p morph-engine-api -p morph-reth
  • cargo clippy -p morph-engine-api --all-targets -- -D warnings

Summary by CodeRabbit

  • Chores
    • Simplified internal instrumentation for block validation operations by removing detailed timing logs while preserving core validation functionality.

The `new_l2_block engine timing` and `validate_l2_block timing` info
logs fire once per imported block and flood stdout during live sync.
They were added for debugging; per-block durations are already covered
by the `new_l2_block_duration_seconds` and
`validate_l2_block_duration_seconds` metrics.
@coderabbitai

coderabbitai Bot commented Jun 12, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 58037c48-0e50-4ccc-8af4-dbeed0b8b814

📥 Commits

Reviewing files that changed from the base of the PR and between b6c47fb and e5eaebb.

📒 Files selected for processing (1)
  • crates/engine-api/src/builder.rs
💤 Files with no reviewable changes (1)
  • crates/engine-api/src/builder.rs

📝 Walkthrough

Walkthrough

This PR removes timing instrumentation from two block validation functions in the engine API builder. The validate_l2_block and import_l2_block_via_engine functions no longer capture elapsed time or emit detailed timing tracing logs, but their core payload validation and error-handling behavior remains unchanged.

Changes

Timing instrumentation cleanup

Layer / File(s) Summary
validate_l2_block timing removal
crates/engine-api/src/builder.rs
Removes Instant timing setup, elapsed-time tracking, and the detailed validate_l2_block timing tracing log while preserving payload conversion, newPayload execution, error mapping, and success/failure return logic.
import_l2_block_via_engine timing removal
crates/engine-api/src/builder.rs
Removes Instant timing around payload conversion and fork-choice-updated operations, eliminates the new_l2_block engine timing tracing log, and retains newPayload/fork-choice-updated execution with payload-status validation.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~5 minutes

Suggested reviewers

  • chengwenxi

Poem

🐰 Time ticks away but not today,
We've trimmed the clocks from the validation way,
The payload flows on, unadorned and fleet,
The engine block dance remains complete! ✨

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'chore(engine-api): remove per-block debug timing logs' accurately and concisely summarizes the main change—removing debug timing logs that were flooding stdout during block import.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch chore/remove-per-block-timing-logs

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@chengwenxi chengwenxi merged commit 38f8a13 into main Jun 15, 2026
14 checks passed
@chengwenxi chengwenxi deleted the chore/remove-per-block-timing-logs branch June 15, 2026 02:50
@panos-xyz panos-xyz mentioned this pull request Jun 22, 2026
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants