chore(release): bump minor rather than major for pre-1.0 breaking changes - #25
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note: this PR was drafted by Claude via back-and-forth with @njbrake. The reasoning and decisions are his; the prose is Claude's.
Preventive: without
bump-minor-pre-major, release-please turns the first breaking-change commit in a pre-1.0 package into a1.0.0proposal. This SDK is pre-1.0 and the Release workflow publishes on release-PR merge, so an accidental 1.0.0 would be a stability signal that can only be yanked, not withdrawn.otari-sdk-rust hit this for real (release-please proposed
1.0.0, corrected to0.3.0in mozilla-ai/otari-sdk-rust#53). Same one-line change here before it can happen.No behaviour change today: there are no
!commits pending since the last tag, so the queued release PR keeps its current version.feat:still bumps the minor, sincebump-patch-for-minor-pre-majoris deliberately left unset.Validated against the release-please config schema.