Bug 1896310 - Attached images are not displayed inline when the bug has no keywords

[kyoshino]

Bug 1896310 - Attached images are not displayed inline when the bug has no keywords

Remove the unnecessary check for bug_keywords introduced in #2132 and simplify the keyword test condition.

[kyoshino]

Will figure out why the selenium test fails. Seems unrelated to the change, but not sure.

[dklawren]

Will figure out why the selenium test fails. Seems unrelated to the change, but not sure.

Yeah was looking at that myself just now. Something to with the check where we turn off attachment display in the admin params, then the attachment should only be downloadable and not viewable. Maybe we should also not display attachments inline if the attachment display parameter is set to off. If you click on the details link, it already blocks displaying the attachment.

[kyoshino]

Added debug code to the security test:

diag $sel->driver->execute_script('return document.body.innerHTML;');

And I could find the patch content in the dumped HTML:

#   </div><div id="att-5" class="attachment" data-id="5" itemscope="" itemtype="http://schema.org/MediaObject">
#       <meta itemprop="name" content="file_4.txt">
#       <meta itemprop="contentSize" content="819">
#       <meta itemprop="encodingFormat" content="text/plain">
#       <div class="label">
#         Attached file
#           <a class="link" href="attachment.cgi?id=5" itemprop="contentUrl">
#         <span id="att-5-description" itemprop="description">simple patch, v1</span></a>
#         — <a href="attachment.cgi?id=5&amp;action=edit" itemprop="url" data-details="1">Details</a>
#       </div>
#     <button type="button" role="link" title="file_4.txt" class="outer"><pre class=" language-plain" role="img" itemprop="text">Index: Bugzilla/Config/MTA.pm
# ===================================================================
# RCS file: /cvsroot/mozilla/webtools/bugzilla/Bugzilla/Config/MTA.pm,v
# retrieving revision 1.13
# diff -3 -p -u -r1.13 MTA.pm
# --- Bugzilla/Config/MTA.pm  13 Nov 2006 23:32:28 -0000  1.13
# +++ Bugzilla/Config/MTA.pm  9 Dec 2006 12:19:44 -0000
# @@ -44,7 +44,9 @@ sub get_param_list {
#    {
#     name =&gt; 'mail_delivery_method',
#     type =&gt; 's',
# -   choices =&gt; [Email::Send-&gt;new()-&gt;all_mailers(), 'None'],
# +   # Bugzilla is not ready yet to send mails to newsgroups, and 'IO'
# +   # is of no use for now as we already have our own 'Test' mode.
# +   choices =&gt; [grep {$_ ne 'NNTP' &amp;&amp; $_ ne 'IO'} Email::Send-&gt;new()-&gt;all_mailers(), 'None'],
#     default =&gt; 'Sendmail',
#     checker =&gt; \&amp;check_mail_delivery_method
#    },
# </pre></button></div>

[dklawren]

Nice. Thanks!