Conversation
…ry cache This seems to be a lot faster. But it does NOT yet do the full label check.
badboy
added this pull request to stack #3665
September 25, 2026 15:01
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This seems to be a lot faster.
But it does NOT yet do the full label check.
One thing why even with
delay_ping_lifetime_iothe new code is slower is that we still do the SQLite machinery, which can get heavy I guess.This re-implements the same BTreeMap-powered cache again, avoiding SQLite for all those in-memory recordings.
It does not yet do the proper label check, but it's good enough for a first test run to see if it gets us closer to the old numbers again.
On my mac I ran the benchmarks as following:
Get the Rkv baseline:
Then run again against the SQLite code:
Results from today:
I'm not sure why the
no flushbenchmark regressed. I did have it at least within noise up to 1.5% faster.But that's also not a mode any app would run in anyway.