fix: use cveMetadata.cveId in CNA basic rule - #25
Merged
Conversation
mprpic
approved these changes
Jul 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes a bug introduced in PR #21 where the CNA basic validation rule incorrectly expected the CVE ID to be located at
cveMetadata.id.Per the CVE v5 JSON schema, the correct and canonical field name is
cveMetadata.cveId. Using the incorrect fieldidcaused the linter to falsely fail valid CVE records with a "CVE ID must be present" error.Changes
CheckCNARulesV4_0Basicininternal/rules/cna_rules.goto extract and validatecveMetadata.cveId.internal/rules/cna_rules_test.goto reflect the correct schema structure, replacing legacyidfields withcveId.references.go), which already correctly utilizescveId.Validation
go test ./internal/rules -run TestCheckCNARulesV4_0Basicpasses with the updated schema-compliant fixtures.go test ./...passes with zero regressions.