WebSocketPeer closing silently

[J-Klinke]

Hi, i'm not entirely sure that this is an issue concerning your plugin rather that concerning the WebSocketPeer class.

However, if you send a message larger than WebSocketPeer's inbound_buffer_size the WebSocketPeer started by your Plugin just silently closes.

I think it would be very nice to print _websocket.get_close_reason() if this happens (to the error/warnig log)? in engineio.gd line 73

I spent quite a lot of time trying to figure out why the connection stopped.

cheers!
Jules

[garciaf]

@msabaeian
So I think I had a similar issue. _websocket have a maximum size of data that is allowed to send. If you reach this limit, I think it would refuse to send anything.
Could one option be to have a method to configure the WebSocket itself? Since it's a private attribute, it can be strange to write socket_io._websocket.inbound_buffer_size = 123445 or exposing _websocket as a public attribute, or even be selective about the attributes we allow to overwrite outbound_buffer_size and inbound_buffer_size and the value will be transmitted.

The case I had was when I was trying to send images through the socket. So I reduced to stay in this limit.

It is a very specific case, and as long as you only send text, you should not encounter this issue too often. But leaving the option open could not hurt. What do you think @msabaeian ?

[msabaeian]

I haven’t personally run into this issue yet but since both of you have seen something similar it’s likely other users may hit the same limitation eventually, I don't like to expose _websocket for now too. we should probably add a error/warning for this issue and explain reason to user. about your suggestion I like it, maybe we can add other options as well like outbound_buffer_size and possibly max_queued_packets(?), so probably something like this:

socket_io.configure_websocket({
    "inbound_buffer_size": 131072,
    "outbound_buffer_size": 131072
})

or:

socket_io.set_websocket_buffer_sizes(inbound_size, outbound_size)