fix: restore protected population in RegionalPopulation (MIC-67)#476
Open
mtiller wants to merge 1 commit into
Open
Conversation
Commit 00e0417 changed this declaration from protected to public solely to get it compiling, noting the cause was unclear. Under OpenModelica 1.24.0 / MSL 3.2.3 the protected binding checks cleanly (verified in isolation: protected vs public makes no difference), so the band-aid is unnecessary. Revert to protected to restore the original intent that the variable is internal to the component. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes MIC-67.
Commit
00e04171(Feb 2025) flippedpopulationfromprotectedtopublicjust to get it compiling, with a note that the cause was unclear.Under OpenModelica 1.24.0 / MSL 3.2.3 the
protectedbinding checks cleanly — I isolated the pattern (a protected variable bound to a connector's potential variable) and confirmedprotectedvspublicmakes no difference on current OMC. The 2025 error was version-specific. This reverts toprotected, restoring the original pedagogy.🤖 Generated with Claude Code