feat: add model regression check tool (MIC-71)#477
Open
mtiller wants to merge 1 commit into
Open
Conversation
Runs checkModel over every class in the ModelicaByExample library under a modern OpenModelica (in Docker) and fails only on a class that breaks but is not in known_failures.txt, so it can gate CI against future OMC/MSL upgrades. Validated against OMC 1.24.0 / MSL 3.2.3: 516 pass, 2 known, 0 unexpected. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes MIC-71.
Adds
tools/check-models/— a repeatable guard that every class inModelicaByExamplestill passescheckModelunder a modern OpenModelica:run.sh— runs the sweep in Docker, verdicts against the allowlist, exits non-zero on new failures. Configurable viaOMC_IMAGE/MSL_VERSION/OMC_LIBS.check_all.mos.in— OMC script template (enumerate all classes, checkModel each).parse.py— pass/fail verdict; also reports known failures that have started passing.known_failures.txt— allowlist (currently ConventionalOnOffControl/MIC-68 and ABCD/MIC-69, with reasons).README.md— usage + config.Validated cold and warm:
Checked 518 classes: 516 passed, 2 failed (2 known, 0 unexpected). OK — no regressions. (exit 0). Ready to wire into CI under MIC-75. Host deps: docker + python3.🤖 Generated with Claude Code