ci(MIC-95): upgrade Node container one major version at a time#480
Merged
mtiller merged 11 commits intoJun 29, 2026
Merged
Conversation
The build/deploy workflow currently only runs on push to master, which means risky CI changes (like the upcoming Node version bumps) can't be proven in a PR — they only get tested after merge, when failure has already shipped to Netlify. Extends the trigger to `pull_request` events (opened/synchronize/ reopened/labeled), and gates each job with: if: github.event_name == 'push' || contains(github.event.pull_request.labels.*.name, 'Full Build') Master pushes are unchanged. PRs run the full pipeline only when the "Full Build" label is applied, keeping default PR overhead at zero. Refs MIC-95.
mtiller
force-pushed
the
michaeltiller/mic-95-replace-node14-container-in-generate_site-job
branch
from
June 29, 2026 03:11
1799c93 to
9a237f9
Compare
Verified 16/18/20/22/24 all green in earlier commits; landing on 22 as the Active LTS gives the longest support window. Also aligns generate_site and deploy_site on the same runtime so debugging only ever needs one mental model.
mtiller
marked this pull request as ready for review
June 29, 2026 15:18
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Result
Climbed the entire Node ladder, one major per commit. Landing on node:26 (Current) for both
generate_siteanddeploy_site— most future-proof choice; works today and won't need revisiting when 26 becomes Active LTS in Oct 2026.Climbing log
pull_requestflowgenerate_site→ node:16generate_site→ node:18error:0308010C:digital envelope routines::unsupportedNODE_OPTIONS=--openssl-legacy-providergenerate_site→ node:20generate_site→ node:22generate_site→ node:24corepack enableattemptnpm install -g yarnWhat's in the diff that matters
generate_sitecontainer:node:14→node:26deploy_sitecontainer:node:18→node:26(alignment, same runtime everywhere)npm install -g yarnstep beforemake site— required because node:25+ images ship without yarn or corepack (corepack was deprecated in Node 25 and removed from the official image).NODE_OPTIONS=--openssl-legacy-providerenv var onmake site(required for Webpack 4 on Node 17+ untilbook-nextgenupgrades its build chain).pull_requesttrigger gated by Full Build label (the mechanism that let us iterate this PR end-to-end).Future-proofing notes
book-nextgenmigrates off yarn 1.x classic.Closes MIC-95.