Skip to content

Fix cloud sync when rclone progress is enabled - #635

Merged
mtkennerly merged 1 commit into
mtkennerly:masterfrom
bm1016bm-svg:codex/fix-rclone-progress-output
Aug 2, 2026
Merged

mtkennerly merged 1 commit into
mtkennerly:masterfrom
bm1016bm-svg:codex/fix-rclone-progress-output

Conversation

@bm1016bm-svg

Copy link
Copy Markdown
Contributor

Summary

  • force terminal progress off for sync commands so the JSON log parser receives only JSON records
  • append the override after custom Rclone arguments; the command-line value also overrides RCLONE_PROGRESS
  • add a regression test for the effective argument order and required JSON logging flags

Testing

  • git diff --check
  • Rust tests were not run locally because this machine does not have a Rust toolchain; upstream CI will compile and test the change

Fixes #627

@mtkennerly mtkennerly added this to the v0.32.0 milestone Aug 2, 2026
@mtkennerly mtkennerly added the bug Something isn't working label Aug 2, 2026
@mtkennerly

Copy link
Copy Markdown
Owner

Thanks! Tested and this works great.

@mtkennerly
mtkennerly merged commit 3ae0d31 into mtkennerly:master Aug 2, 2026
9 checks passed
mtkennerly added a commit that referenced this pull request Aug 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Cloud sync fails when rclone --progress is set to true

2 participants