Expose manifest file tags in the API output - #645
Merged
Merged
Conversation
Owner
|
Thanks! This looks good 👍 |
mtkennerly
added a commit
that referenced
this pull request
Aug 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a
tagsfield to each file in the--apiJSON output, so consumers can tell which files are saves versus configs (and anything else the manifest tags). This is what #534 asked for.The tags come straight from the manifest entries that matched a file, so a file gets
save,config, etc. based on the paths it was found under. As mentioned in the issue, paths can overlap (for example a config directory that contains the save directory), so when more than one manifest entry resolves to the same file its tags are unioned rather than one winning. The field is omitted when empty, so existing output is unchanged and restore output (which has no manifest tags) is unaffected.Implementation notes
ScannedFilenow carries the tags collected while scanning for backup.ApiFileexposes them astags, skipped when empty.I left the generated
docs/schemafiles alone since regenerating them here also pulls in an unrelated schemars format bump, so that seems better left for a release.Testing
cargo testcargo fmt --all -- --checkcargo clippy --workspace -- --deny warningsAdded
can_scan_game_for_backup_with_tagscovering a config file and a save directory.Closes #534